-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): introduce parquet file source #17201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabVersion
reviewed
Jun 17, 2024
src/connector/src/source/filesystem/opendal_source/opendal_reader.rs
Outdated
Show resolved
Hide resolved
src/connector/src/source/filesystem/opendal_source/opendal_reader.rs
Outdated
Show resolved
Hide resolved
src/connector/src/source/filesystem/opendal_source/opendal_reader.rs
Outdated
Show resolved
Hide resolved
hzxa21
reviewed
Jul 11, 2024
src/connector/src/source/filesystem/opendal_source/opendal_reader.rs
Outdated
Show resolved
Hide resolved
xxchan
reviewed
Jul 11, 2024
xxchan
reviewed
Jul 11, 2024
xxchan
reviewed
Jul 11, 2024
xxchan
reviewed
Jul 11, 2024
hzxa21
reviewed
Jul 11, 2024
src/connector/src/source/filesystem/opendal_source/opendal_reader.rs
Outdated
Show resolved
Hide resolved
hzxa21
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This pr introduce a new encode
parquet
for file source, user can read.parquet
files viaChecklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
This pr introduce parquet file source, and user can use file source to read parquet file. The syntax is: