Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): enable sink_decouple by default for kafka, pulsar, kinesis, google pubsub, nats, mqtt clickhouse #17221

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Jun 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17095

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

update:
After this pr kafka, pulsar, kinesis, google pubsub, nats, mqtt clickhouse sink‘s sink_decouple will be true by default

@xxhZs xxhZs requested review from wenym1 and hzxa21 June 13, 2024 07:43
@xxhZs xxhZs added the user-facing-changes Contains changes that are visible to users label Jun 13, 2024
@xxhZs xxhZs enabled auto-merge June 13, 2024 07:54
@xxhZs xxhZs added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 5c24685 Jun 14, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/decouple_default_1 branch June 14, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants