Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): add function pg_index_column_has_property #17275

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

wangrunji0408
Copy link
Contributor

Signed-off-by: Runji Wang [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #17245

This PR adds support for pg_index_column_has_property function to query index column properties.

Currently we have property asc, desc, nulls_first, nulls_last. But they are not stored in the index catalog. This PR also adds them to the catalog.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

support function pg_index_column_has_property

pg_index_column_has_property ( index regclass, column integer, property text ) → boolean

supported index properties: asc, desc, nulls_first, nulls_last

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
I never expected that we had to implement migration logic in order to adding a system table.

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You're so fast!

Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit e34c83b Jun 17, 2024
32 of 33 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/pg_index_column_has_property branch June 17, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pg_index_column_has_property
3 participants