Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): support glue catalog #17477

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat(iceberg): support glue catalog #17477

merged 5 commits into from
Jun 27, 2024

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Resolve feat: support glue catalog for iceberg #17476
  • Support glue catalog for iceberg sink and source. JNI is used to support the glue catalog, so we just need to configure the right properties for org.apache.iceberg.aws.glue.GlueCatalog

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support glue catalog for iceberg sink and source.

Example

create sink sink_test from t
with (
    type='upsert',
    primary_key='col',
    connector = 'iceberg',
    catalog.type = 'glue',
    catalog.name = 'test',
    warehouse.path = 's3://my-iceberg-bucket/test',
    s3.access.key = 'xxxxxxxxxx',
    s3.secret.key = 'xxxxxxxxxx',
    s3.region = 'ap-southeast-2',
    database.name='test_db',
    table.name='test_table'
);

create source source_test
with (
    connector = 'iceberg',
    catalog.type = 'glue',
    warehouse.path = 's3://my-iceberg-bucket/test',
    s3.access.key = 'xxxxxxxxxx',
    s3.secret.key = 'xxxxxxxxxx',
    s3.region = 'ap-southeast-2',
    database.name='test_db',
    table.name='test_table'
);

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5161 files.

Valid Invalid Ignored Fixed
2206 1 2954 0
Click to see the invalid file list
  • java/connector-node/risingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/GlueCredentialProvider.java

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Jun 27, 2024
…risingwave/connector/catalog/GlueCredentialProvider.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines 44 to 47
pub s3_access: String,
#[serde(rename = "s3.secret.key", default)]
#[serde(rename = "s3.secret.key")]
pub s3_secret: String,
#[serde(rename = "warehouse.path")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the user is running on gcp or azure? 😅
Looks like the s3 ak/sk should only be "conditionally" required when aws glue is used. Otherwise it should be optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, if users want to use glue, they should use S3 as well. We can separate the configuration for glue and s3 if we have the requirement.

Copy link
Contributor

@neverchanje neverchanje Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I only consider that we should offer other storage options in the future when using other catalog .

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user-facing interface LGTM.

@chenzl25 chenzl25 added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 168d436 Jun 27, 2024
32 of 33 checks passed
@chenzl25 chenzl25 deleted the dylan/support_glue_catalog branch June 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support glue catalog for iceberg
2 participants