Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix changelog append_only #17583

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(frontend): fix changelog append_only #17583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions integration_tests/snowflake-sink/upsert/create_sink.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,4 @@ CREATE SINK snowflake_sink FROM ss_mv WITH (
snowflake.aws_secret_access_key = 'EXAMPLE_SECRET_KEY',
snowflake.aws_region = 'EXAMPLE_REGION',
snowflake.s3_path = 'EXAMPLE_S3_PATH',
-- depends on your mv setup, note that snowflake sink *only* supports
-- `append-only` mode at present.
force_append_only = 'true'
);
3 changes: 2 additions & 1 deletion src/frontend/src/optimizer/plan_node/stream_changelog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ impl StreamChangeLog {
let base = PlanBase::new_stream_with_core(
&core,
dist,
input.append_only(),
// The changelog will convert all delete/update to insert, so it must be true here.
true,
input.emit_on_window_close(),
watermark_columns,
);
Expand Down
Loading