Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support encode jsonb data as dynamic json type in sink #17693

Merged
merged 9 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
333 changes: 175 additions & 158 deletions src/connector/src/sink/encoder/json.rs

Large diffs are not rendered by default.

27 changes: 27 additions & 0 deletions src/connector/src/sink/encoder/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,33 @@ pub enum CustomJsonType {
None,
}

/// How the jsonb type is encoded.
///
/// - `String`: encode jsonb as string. `[1, true, "foo"] -> "[1, true, \"foo\"]"`
/// - `Dynamic`: encode jsonb as json type dynamically. `[1, true, "foo"] -> [1, true, "foo"]`
/// - `Custom`: decided by [`CustomJsonType`].
pub enum EncodeJsonbMode {
String,
Dynamic,
Custom,
}

impl EncodeJsonbMode {
pub const OPTION_KEY: &'static str = "encode.jsonb.mode";
yuhao-su marked this conversation as resolved.
Show resolved Hide resolved

pub fn from_options(options: &BTreeMap<String, String>) -> Result<Self> {
match options.get(Self::OPTION_KEY).map(std::ops::Deref::deref) {
Some("string") | None => Ok(Self::String),
Some("dynamic") => Ok(Self::Dynamic),
Some(v) => Err(super::SinkError::Config(anyhow::anyhow!(
"unrecognized {} value {}",
Self::OPTION_KEY,
v
))),
}
}
}

#[derive(Debug)]
struct FieldEncodeError {
message: String,
Expand Down
7 changes: 5 additions & 2 deletions src/connector/src/sink/formatter/debezium_json.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ use tracing::warn;

use super::{Result, SinkFormatter, StreamChunk};
use crate::sink::encoder::{
DateHandlingMode, JsonEncoder, RowEncoder, TimeHandlingMode, TimestampHandlingMode,
TimestamptzHandlingMode,
DateHandlingMode, EncodeJsonbMode, JsonEncoder, RowEncoder, TimeHandlingMode,
TimestampHandlingMode, TimestamptzHandlingMode,
};
use crate::tri;

Expand Down Expand Up @@ -69,6 +69,7 @@ impl DebeziumJsonFormatter {
TimestampHandlingMode::Milli,
TimestamptzHandlingMode::UtcString,
TimeHandlingMode::Milli,
EncodeJsonbMode::String,
);
let val_encoder = JsonEncoder::new(
schema.clone(),
Expand All @@ -77,6 +78,7 @@ impl DebeziumJsonFormatter {
TimestampHandlingMode::Milli,
TimestamptzHandlingMode::UtcString,
TimeHandlingMode::Milli,
EncodeJsonbMode::String,
);
Self {
schema,
Expand Down Expand Up @@ -397,6 +399,7 @@ mod tests {
TimestampHandlingMode::Milli,
TimestamptzHandlingMode::UtcString,
TimeHandlingMode::Milli,
EncodeJsonbMode::String,
);
let json_chunk = chunk_to_json(chunk, &encoder).unwrap();
let schema_json = schema_to_json(&schema, "test_db", "test_table");
Expand Down
5 changes: 4 additions & 1 deletion src/connector/src/sink/formatter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ use super::catalog::{SinkEncode, SinkFormat, SinkFormatDesc};
use super::encoder::template::TemplateEncoder;
use super::encoder::text::TextEncoder;
use super::encoder::{
DateHandlingMode, KafkaConnectParams, TimeHandlingMode, TimestamptzHandlingMode,
DateHandlingMode, EncodeJsonbMode, KafkaConnectParams, TimeHandlingMode,
TimestamptzHandlingMode,
};
use super::redis::{KEY_FORMAT, VALUE_FORMAT};
use crate::sink::encoder::{
Expand Down Expand Up @@ -113,13 +114,15 @@ pub trait EncoderBuild: Sized {
impl EncoderBuild for JsonEncoder {
async fn build(b: EncoderParams<'_>, pk_indices: Option<Vec<usize>>) -> Result<Self> {
let timestamptz_mode = TimestamptzHandlingMode::from_options(&b.format_desc.options)?;
let encode_jsonb_mode = EncodeJsonbMode::from_options(&b.format_desc.options)?;
let encoder = JsonEncoder::new(
b.schema,
pk_indices,
DateHandlingMode::FromCe,
TimestampHandlingMode::Milli,
timestamptz_mode,
TimeHandlingMode::Milli,
encode_jsonb_mode,
);
let encoder = if let Some(s) = b.format_desc.options.get("schemas.enable") {
match s.to_lowercase().parse::<bool>() {
Expand Down
3 changes: 2 additions & 1 deletion src/connector/src/sink/kafka.rs
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ mod test {

use super::*;
use crate::sink::encoder::{
DateHandlingMode, JsonEncoder, TimeHandlingMode, TimestampHandlingMode,
DateHandlingMode, EncodeJsonbMode, JsonEncoder, TimeHandlingMode, TimestampHandlingMode,
TimestamptzHandlingMode,
};
use crate::sink::formatter::AppendOnlyFormatter;
Expand Down Expand Up @@ -778,6 +778,7 @@ mod test {
TimestampHandlingMode::Milli,
TimestamptzHandlingMode::UtcString,
TimeHandlingMode::Milli,
EncodeJsonbMode::String,
),
)),
)
Expand Down
7 changes: 4 additions & 3 deletions src/connector/src/sink/mqtt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ use with_options::WithOptions;

use super::catalog::{SinkEncode, SinkFormat, SinkFormatDesc};
use super::encoder::{
DateHandlingMode, JsonEncoder, ProtoEncoder, ProtoHeader, RowEncoder, SerTo, TimeHandlingMode,
TimestampHandlingMode, TimestamptzHandlingMode,
DateHandlingMode, EncodeJsonbMode, JsonEncoder, ProtoEncoder, ProtoHeader, RowEncoder, SerTo,
TimeHandlingMode, TimestampHandlingMode, TimestamptzHandlingMode,
};
use super::writer::AsyncTruncateSinkWriterExt;
use super::{DummySinkCommitCoordinator, SinkWriterParam};
Expand Down Expand Up @@ -221,7 +221,7 @@ impl MqttSinkWriter {
}

let timestamptz_mode = TimestamptzHandlingMode::from_options(&format_desc.options)?;

let encode_jsonb_mode = EncodeJsonbMode::from_options(&format_desc.options)?;
let encoder = match format_desc.format {
SinkFormat::AppendOnly => match format_desc.encode {
SinkEncode::Json => RowEncoderWrapper::Json(JsonEncoder::new(
Expand All @@ -231,6 +231,7 @@ impl MqttSinkWriter {
TimestampHandlingMode::Milli,
timestamptz_mode,
TimeHandlingMode::Milli,
encode_jsonb_mode,
)),
SinkEncode::Protobuf => {
let (descriptor, sid) = crate::schema::protobuf::fetch_descriptor(
Expand Down
5 changes: 4 additions & 1 deletion src/connector/src/sink/nats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ use tokio_retry::strategy::{jitter, ExponentialBackoff};
use tokio_retry::Retry;
use with_options::WithOptions;

use super::encoder::{DateHandlingMode, TimeHandlingMode, TimestamptzHandlingMode};
use super::encoder::{
DateHandlingMode, EncodeJsonbMode, TimeHandlingMode, TimestamptzHandlingMode,
};
use super::utils::chunk_to_json;
use super::{DummySinkCommitCoordinator, SinkWriterParam};
use crate::connector_common::NatsCommon;
Expand Down Expand Up @@ -151,6 +153,7 @@ impl NatsSinkWriter {
TimestampHandlingMode::Milli,
TimestamptzHandlingMode::UtcWithoutSuffix,
TimeHandlingMode::Milli,
EncodeJsonbMode::String,
),
})
}
Expand Down
4 changes: 3 additions & 1 deletion src/connector/src/sink/snowflake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ use uuid::Uuid;
use with_options::WithOptions;

use super::encoder::{
JsonEncoder, RowEncoder, TimeHandlingMode, TimestampHandlingMode, TimestamptzHandlingMode,
EncodeJsonbMode, JsonEncoder, RowEncoder, TimeHandlingMode, TimestampHandlingMode,
TimestamptzHandlingMode,
};
use super::writer::LogSinkerOf;
use super::{SinkError, SinkParam};
Expand Down Expand Up @@ -193,6 +194,7 @@ impl SnowflakeSinkWriter {
TimestampHandlingMode::String,
TimestamptzHandlingMode::UtcString,
TimeHandlingMode::String,
EncodeJsonbMode::String,
),
// initial value of `epoch` will be set to 0
epoch: 0,
Expand Down
Loading