Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(streaming): fix order assumption in extreme_null #1770

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao [email protected]

What's changed and what's your intention?

We have no assumption about the order of inserted rows.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@BugenZhao BugenZhao requested review from skyzh and StrikeW April 11, 2022 10:46
@BugenZhao BugenZhao enabled auto-merge (squash) April 11, 2022 10:46
@github-actions github-actions bot added the component/test Test related issue. label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1770 (61f1fcc) into main (a933494) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1770   +/-   ##
=======================================
  Coverage   71.15%   71.15%           
=======================================
  Files         601      601           
  Lines       77950    77950           
=======================================
+ Hits        55466    55469    +3     
+ Misses      22484    22481    -3     
Flag Coverage Δ
rust 71.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.89%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao merged commit 01947e4 into main Apr 11, 2022
@BugenZhao BugenZhao deleted the bz/fix-order-in-extreme-null-slt branch April 11, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants