refactor: use separate configuration for exchange connection pool for batch and streaming #17768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
4 tasks
BugenZhao
force-pushed
the
bz/stream-client-pool
branch
from
0b0cb85
to
eca1565
Compare
BugenZhao
force-pushed
the
bz/client-pool-separate-config
branch
from
0991157
to
f5ae55d
Compare
BugenZhao
added
the
user-facing-changes
… batch and streaming
BugenZhao
force-pushed
the
bz/client-pool-separate-config
branch
from
f5ae55d
to
0be5d74
Compare
chenzl25
approved these changes
Jul 23, 2024
kwannoel
added
the
need-cherry-pick-release-1.10
kwannoel
pushed a commit
that referenced
this pull request
Jul 25, 2024
… batch and streaming (#17768)
9 tasks
kwannoel
pushed a commit
that referenced
this pull request
Jul 25, 2024
… batch and streaming (#17768)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
… batch and streaming (#17768) (#17808) Co-authored-by: Bugen Zhao <[email protected]>
2 tasks
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See comment from @kwannoel in #17755 (review) for the background.
Follow-up of #17755. Introduce two configuration entries of
batch.developer.exchange_connection_pool_sizeandstreaming.developer.exchange_connection_pool_size, which override theserver.connection_pool_sizeif set.The default values of them are set to
NoneandSome(1)correspondingly to be compatible with the behavior before this and the previous PR.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Introduce two configuration entries of
batch.developer.exchange_connection_pool_sizeandstreaming.developer.exchange_connection_pool_size. See documentation for more details.