Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): switch to RowRefV2 #1818

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

Follow up to #1813

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TennyZhuang TennyZhuang enabled auto-merge (squash) April 13, 2022 10:19
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1818 (4adb549) into main (54f6fe8) will decrease coverage by 0.71%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
- Coverage   71.37%   70.65%   -0.72%     
==========================================
  Files         607      607              
  Lines       79406    79241     -165     
==========================================
- Hits        56673    55985     -688     
- Misses      22733    23256     +523     
Flag Coverage Δ
rust 70.65% <79.16%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/lib.rs 100.00% <ø> (ø)
src/common/src/array/stream_chunk.rs 84.03% <16.66%> (-6.25%) ⬇️
src/common/src/array/stream_chunk_iter.rs 93.67% <100.00%> (+5.43%) ⬆️
src/stream/src/executor/debug/update_check.rs 87.35% <100.00%> (-1.15%) ⬇️
src/stream/src/executor_v2/hop_window.rs 81.57% <100.00%> (ø)
src/stream/src/executor/merge.rs 0.00% <0.00%> (-100.00%) ⬇️
src/stream/src/executor/project.rs 0.00% <0.00%> (-87.10%) ⬇️
src/common/src/util/env_var.rs 0.00% <0.00%> (-75.00%) ⬇️
src/stream/src/executor/debug/trace.rs 0.00% <0.00%> (-67.80%) ⬇️
src/stream/src/task/stream_manager.rs 0.00% <0.00%> (-52.46%) ⬇️
... and 24 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit 59b6898 into main Apr 13, 2022
@TennyZhuang TennyZhuang deleted the refactor/rows-v2-to-rows branch April 13, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants