Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow config the interval of list files #18184

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Aug 22, 2024

Signed-off-by: tabVersion [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

introduce refresh.interval.sec option for S3, GCS, and POSIX source, allowing config the time interval between two list object actions. The config affects the time delay for discovering new files. Default to 60s (1 min)

Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion marked this pull request as ready for review August 22, 2024 07:42
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion merged commit acca0b3 into tab/fix-s3-read-file Aug 22, 2024
25 of 26 checks passed
@tabVersion tabVersion deleted the tab/list-file-interval branch August 22, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants