Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): hash dispatcher: support multi columns #222

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 10, 2022

What's changed and what's your intention?

as title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

closes #210

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #222 (7ed1bd1) into main (0b82d5f) will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #222      +/-   ##
============================================
- Coverage     74.57%   74.55%   -0.03%     
- Complexity     2654     2656       +2     
============================================
  Files           839      839              
  Lines         47900    47933      +33     
  Branches       1562     1566       +4     
============================================
+ Hits          35721    35736      +15     
- Misses        11380    11397      +17     
- Partials        799      800       +1     
Flag Coverage Δ
java 62.04% <0.00%> (-0.04%) ⬇️
rust 79.95% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngwave/planner/rel/streaming/RwStreamExchange.java 59.72% <0.00%> (ø)
rust/meta/src/stream/graph/stream_graph.rs 86.95% <0.00%> (-3.96%) ⬇️
rust/meta/src/stream/test_fragmenter.rs 98.55% <ø> (ø)
rust/stream/src/task/test_mv.rs 100.00% <ø> (ø)
rust/stream/src/task/stream_manager.rs 52.35% <100.00%> (-0.12%) ⬇️
rust/stream/src/task/tests.rs 100.00% <100.00%> (ø)
...gwave/planner/planner/streaming/StreamPlanner.java 83.16% <0.00%> (-5.97%) ⬇️
rust/stream/src/task/barrier_manager.rs 93.25% <0.00%> (-1.06%) ⬇️
rust/storage/src/table/mview.rs 69.82% <0.00%> (-0.97%) ⬇️
...main/java/com/risingwave/catalog/TableCatalog.java 78.84% <0.00%> (-0.57%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b82d5f...7ed1bd1. Read the comment docs.

@TennyZhuang TennyZhuang merged commit 6f53766 into main Feb 10, 2022
@TennyZhuang TennyZhuang deleted the eric/fix_hash_dispatcher branch February 10, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: streaming: supports multiple distribution key for HashDispatcher
3 participants