Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): differentiate listen addr and advertise addr #2286

Merged
merged 2 commits into from
May 4, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 4, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

  • Advertise addr -- client will connect to a service using this addr.
  • Listen addr -- generally 0.0.0.0 or 127.0.0.1, the addr to listen on.
  • MinIO is now using default root credentials instead of creating a new user.

In this PR, we differentiate listen addr and advertise addr, so as to make #2285 possible.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh enabled auto-merge (squash) May 4, 2022 03:54
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2286 (f0a4f39) into main (6fb6932) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   71.26%   71.25%   -0.01%     
==========================================
  Files         655      655              
  Lines       83611    83616       +5     
==========================================
- Hits        59585    59584       -1     
- Misses      24026    24032       +6     
Flag Coverage Δ
rust 71.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/bin/risedev-playground.rs 0.29% <0.00%> (ø)
src/risedevtool/src/config_gen/frontend_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/grafana_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/kafka_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/prometheus_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/zookeeper_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/compactor_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/compute_node_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/etcd_service.rs 0.00% <0.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit d3dd50d into main May 4, 2022
@skyzh skyzh deleted the skyzh/advertise-addr branch May 4, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants