Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix cron invalid workflow #2307

Merged
merged 3 commits into from
May 4, 2022
Merged

ci: fix cron invalid workflow #2307

merged 3 commits into from
May 4, 2022

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented May 4, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Close #2304

@TennyZhuang
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2307 (e552916) into main (bd10ebd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2307   +/-   ##
=======================================
  Coverage   71.04%   71.04%           
=======================================
  Files         665      665           
  Lines       83670    83670           
=======================================
+ Hits        59446    59447    +1     
+ Misses      24224    24223    -1     
Flag Coverage Δ
rust 71.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang
Copy link
Contributor Author

image

It seems that ec2-c do nothing :(

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang
Copy link
Contributor Author

@TennyZhuang
Copy link
Contributor Author

You can add ec2-c back while you add connector tests later :(

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also help change the permissions of main-cron.yml to

permissions:
  id-token: write
  contents: write

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang
Copy link
Contributor Author

@TennyZhuang TennyZhuang merged commit 70626c4 into main May 4, 2022
@TennyZhuang TennyZhuang deleted the ci/fix-cron branch May 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: main cron job never runs
2 participants