Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): add test for delta join with projection #2314

Merged
merged 2 commits into from
May 5, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 5, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. Anyway, if there's projection between HashJoin and IndexScan, then the plan cannot be converted to delta join (for now). This PR adds test for projection outside join.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from fuyufjh May 5, 2022 04:10
@skyzh skyzh enabled auto-merge (squash) May 5, 2022 04:18
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2314 (3175973) into main (bb71a45) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2314      +/-   ##
==========================================
+ Coverage   71.03%   71.08%   +0.04%     
==========================================
  Files         665      665              
  Lines       83705    83705              
==========================================
+ Hits        59461    59500      +39     
+ Misses      24244    24205      -39     
Flag Coverage Δ
rust 71.08% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 24.30% <0.00%> (+0.19%) ⬆️
src/frontend/src/utils/condition.rs 97.39% <0.00%> (+1.73%) ⬆️
...ntend/src/optimizer/plan_node/eq_join_predicate.rs 85.52% <0.00%> (+3.94%) ⬆️
...ontend/src/optimizer/plan_node/stream_hash_join.rs 97.16% <0.00%> (+29.24%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh merged commit 5df3838 into main May 5, 2022
@skyzh skyzh deleted the skyzh/index-projection branch May 5, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants