Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bitmap): remove limit of bitmaps in SST #2399

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

soundOfDestiny
Copy link
Contributor

What's changed and what's your intention?

remove limit of bitmaps in SST, since we no longer have 65536 vnodes

Checklist

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #2399 (1539ce1) into main (a90ab3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2399   +/-   ##
=======================================
  Coverage   71.35%   71.35%           
=======================================
  Files         680      680           
  Lines       86185    86183    -2     
=======================================
+ Hits        61497    61498    +1     
+ Misses      24688    24685    -3     
Flag Coverage Δ
rust 71.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/sstable/builder.rs 91.07% <100.00%> (+0.53%) ⬆️
src/stream/src/executor/managed_state/join/mod.rs 70.41% <0.00%> (-0.18%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@soundOfDestiny soundOfDestiny merged commit 709d54e into main May 10, 2022
@soundOfDestiny soundOfDestiny deleted the zl_unlimbitmap branch May 10, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants