Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): do not open port for prometheus test #250

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 11, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh enabled auto-merge (squash) February 11, 2022 06:18
@github-actions github-actions bot added the type/fix Bug fix label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #250 (f7e941a) into main (ff591c2) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #250      +/-   ##
============================================
- Coverage     74.14%   73.91%   -0.23%     
  Complexity     2657     2657              
============================================
  Files           847      847              
  Lines         48110    48082      -28     
  Branches       1567     1567              
============================================
- Hits          35670    35540     -130     
- Misses        11639    11741     +102     
  Partials        801      801              
Flag Coverage Δ
java 62.05% <ø> (ø)
rust 79.01% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/storage/src/hummock/state_store_tests.rs 83.33% <100.00%> (-5.73%) ⬇️
rust/storage/src/hummock/utils.rs 0.00% <0.00%> (-100.00%) ⬇️
rust/storage/src/hummock/mod.rs 40.00% <0.00%> (-43.04%) ⬇️
rust/storage/src/hummock/version_manager.rs 32.32% <0.00%> (-7.08%) ⬇️
rust/storage/src/hummock/value.rs 63.79% <0.00%> (-5.18%) ⬇️
rust/storage/src/hummock/cloud.rs 86.20% <0.00%> (-3.45%) ⬇️
rust/storage/src/hummock/compactor.rs 0.00% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff591c2...f7e941a. Read the comment docs.

@skyzh skyzh merged commit 64f1db4 into main Feb 11, 2022
@skyzh skyzh deleted the skyzh/refactor-storage-prometheus-test branch February 11, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants