Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove legacy java frontend #2523

Merged
merged 9 commits into from
May 14, 2022
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented May 14, 2022

What's changed and what's your intention?

Merge #2519 again.

Remove legacy Java frontend, including sources and tests.

TO REVIEWERS: Click this link to see diffs excluding removing legacy folder -> https:/singularity-data/risingwave/pull/2519/files/2ef98f693fb42eeb1bf0df3facfa95549f4b35f2..HEAD

Some remaining works need to be done later:

  • Check E2E test cases and make sure all cases are covered in v2/ before removing them
  • Migrate regress tests src/tests/regress/ to Rust frontend and enable them
  • Remove compatible code in backend (keyword: is_legacy_frontend)
  • Remove CreateSourceExecutor
  • Remove create_materialized_view and drop_materialized_view in StreamServiceImpl should we depracate StreamServiceImpl's usused functions? #2260
  • Rename all occurrences of "FrontendV2" to "Frontend"

Checklist

N/A

Refer to a related PR or issue link (optional)

None

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #2523 (0457bea) into main (e4a0c3a) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
+ Coverage   71.33%   71.40%   +0.06%     
==========================================
  Files         689      688       -1     
  Lines       88643    88531     -112     
==========================================
- Hits        63232    63213      -19     
+ Misses      25411    25318      -93     
Flag Coverage Δ
rust 71.40% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/struct_array.rs 83.58% <0.00%> (-0.92%) ⬇️
src/risedevtool/src/task.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config.rs 0.00% <0.00%> (ø)
src/frontend/src/binder/values.rs 92.68% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/frontend_service.rs
src/risedevtool/src/bin/risedev-config.rs 0.44% <0.00%> (+0.01%) ⬆️
src/risedevtool/src/bin/risedev-compose.rs 1.12% <0.00%> (+0.01%) ⬆️
src/risedevtool/src/bin/risedev-playground.rs 0.30% <0.00%> (+0.01%) ⬆️
src/storage/src/hummock/local_version_manager.rs 89.88% <0.00%> (+0.03%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fuyufjh fuyufjh merged commit 4af7f7b into main May 14, 2022
@fuyufjh fuyufjh deleted the eric/remove_legacy_frontend branch May 14, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants