Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate legacy e2e tests #2536

Merged
merged 5 commits into from
May 15, 2022
Merged

test: migrate legacy e2e tests #2536

merged 5 commits into from
May 15, 2022

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented May 15, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

Before we fully remove the legacy tests, we should migrate some useful tests.

I've found some issues during migration, and related tests are removed:

#2534
#2533
#2535

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

part of #2538

@github-actions github-actions bot added the component/test Test related issue. label May 15, 2022
@TennyZhuang TennyZhuang changed the title test: migrate boolean.slt from legacy test: migrate legacy e2e tests May 15, 2022
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #2536 (234c59a) into main (fb519e5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   71.39%   71.39%   -0.01%     
==========================================
  Files         688      688              
  Lines       88505    88505              
==========================================
- Hits        63192    63191       -1     
- Misses      25313    25314       +1     
Flag Coverage Δ
rust 71.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit ec86641 into main May 15, 2022
@TennyZhuang TennyZhuang deleted the test/boolean branch May 15, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants