Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clearify HummockClient's location #2544

Merged
merged 3 commits into from
May 16, 2022
Merged

docs: clearify HummockClient's location #2544

merged 3 commits into from
May 16, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 16, 2022

What's changed and what's your intention?

As title

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from fuyufjh May 16, 2022 03:33
@github-actions github-actions bot added the component/doc Issues about documentation. label May 16, 2022
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh enabled auto-merge (squash) May 16, 2022 03:43
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2544 (e6b2ddd) into main (db3c72d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2544   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files         689      689           
  Lines       88528    88555   +27     
=======================================
+ Hits        63209    63231   +22     
- Misses      25319    25324    +5     
Flag Coverage Δ
rust 71.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/conflict_detector.rs 96.01% <0.00%> (-2.86%) ⬇️
src/storage/src/hummock/local_version_manager.rs 89.92% <0.00%> (+0.03%) ⬆️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
...rc/hummock/shared_buffer/shared_buffer_uploader.rs 82.24% <0.00%> (+0.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit b91f6e7 into main May 16, 2022
@skyzh skyzh deleted the skyzh/hummock-docs branch May 16, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants