Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): move v2 tests to be the first citizen #2658

Merged
merged 6 commits into from
May 19, 2022
Merged

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented May 19, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Should be a replace of #2632 . Sorry for the git misop...

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@BowenXiao1999 BowenXiao1999 changed the title Bw/fix e2e test2 chore(e2e): move v2 tests to be the first citizen May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2658 (7f4c92a) into main (3191cc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2658   +/-   ##
=======================================
  Coverage   72.11%   72.11%           
=======================================
  Files         679      679           
  Lines       88361    88361           
=======================================
  Hits        63719    63719           
  Misses      24642    24642           
Flag Coverage Δ
rust 72.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/barrier/mod.rs 67.88% <0.00%> (-0.34%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/meta/src/stream/stream_manager.rs 64.01% <0.00%> (+0.29%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit 7007f1f into main May 19, 2022
@TennyZhuang TennyZhuang deleted the bw/fix-e2e-test2 branch May 19, 2022 05:35
@xxhZs
Copy link
Contributor

xxhZs commented May 19, 2022

The order of insert and create mv in tpch_upstream has been changed, I don't know the difference between it and tpch_snapshot

@BowenXiao1999
Copy link
Contributor Author

The order of insert and create mv in tpch_upstream has been changed, I don't know the difference between it and tpch_snapshot

Insert is ingesting data into table, so we don't care the order with create mv. But indeed it's a meaningless change that add accidently.

I also don't know why tpch_snapshot and tpch_upstream. Maybe relates to data flush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants