Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): pushdown predicate to LogicalScan #2987

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 5, 2022

What's changed and what's your intention?

as title
batch/stream plan (almost) not changed

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #2343

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #2987 (a53e3cd) into main (2a3e88a) will increase coverage by 0.02%.
The diff coverage is 99.23%.

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   72.97%   73.00%   +0.02%     
==========================================
  Files         721      721              
  Lines       96472    96555      +83     
==========================================
+ Hits        70399    70486      +87     
+ Misses      26073    26069       -4     
Flag Coverage Δ
rust 73.00% <99.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/frontend/src/optimizer/plan_node/logical_scan.rs 99.62% <99.19%> (-0.38%) ⬇️
src/frontend/src/handler/create_index.rs 86.82% <100.00%> (-0.11%) ⬇️
src/frontend/src/planner/relation.rs 76.00% <100.00%> (+0.19%) ⬆️
src/frontend/src/scheduler/distributed/query.rs 66.75% <100.00%> (-0.09%) ⬇️
src/frontend/src/scheduler/plan_fragmenter.rs 94.77% <100.00%> (-0.02%) ⬇️
src/frontend/src/utils/mod.rs 66.66% <100.00%> (ø)
src/storage/src/hummock/local_version_manager.rs 90.22% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/compactor.rs 69.68% <0.00%> (+0.17%) ⬆️
src/meta/src/barrier/mod.rs 65.59% <0.00%> (+0.32%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan requested a review from st1page June 5, 2022 21:34
@xxchan xxchan marked this pull request as ready for review June 5, 2022 21:34
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan merged commit d7e6420 into main Jun 6, 2022
@xxchan xxchan deleted the xxchan/scan branch June 6, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: push down all predicate to LogicalScan in logical phase
3 participants