Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore commits in the blame view #2995

Merged
merged 2 commits into from
Jun 6, 2022
Merged

chore: Ignore commits in the blame view #2995

merged 2 commits into from
Jun 6, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 6, 2022

What's changed and what's your intention?

as title
https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

On GitHub

before
image

after
image

Enable Locally

git config blame.ignoreRevsFile .git-blame-ignore-revs

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@skyzh
Copy link
Contributor

skyzh commented Jun 6, 2022

  • GitHub web page doesn't support this 🤣
  • We have a lot of other refactor commits, would you please also help add them in? (like add license, move rust/ to src, etc.)

@xxchan
Copy link
Member Author

xxchan commented Jun 6, 2022

GitHub web page doesn't support this 🤣

It is supported. See the screenshot. 🤔

We have a lot of other refactor commits, would you please also help add them in? (like add license, move rust/ to src, etc.)

OK

@skyzh
Copy link
Contributor

skyzh commented Jun 6, 2022

That's cool, so GitHub has upgraded 🤣

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2995 (998c8e1) into main (6050273) will decrease coverage by 0.01%.
The diff coverage is 66.18%.

@@            Coverage Diff             @@
##             main    #2995      +/-   ##
==========================================
- Coverage   73.01%   72.99%   -0.02%     
==========================================
  Files         722      723       +1     
  Lines       96548    96739     +191     
==========================================
+ Hits        70493    70618     +125     
- Misses      26055    26121      +66     
Flag Coverage Δ
rust 72.99% <66.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/agg.rs 51.35% <0.00%> (-4.54%) ⬇️
...ream/src/executor/managed_state/aggregation/mod.rs 81.48% <ø> (ø)
...rc/meta/src/hummock/compaction/overlap_strategy.rs 47.01% <7.31%> (-18.70%) ⬇️
src/expr/src/vector_op/agg/aggregator.rs 74.17% <33.33%> (-1.69%) ⬇️
src/stream/src/executor/managed_state/join/mod.rs 73.56% <50.00%> (ø)
...rc/expr/src/vector_op/agg/approx_count_distinct.rs 84.10% <84.10%> (ø)
src/frontend/src/binder/expr/function.rs 79.19% <100.00%> (+0.14%) ⬆️
src/frontend/src/expr/agg_call.rs 55.29% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.86% <100.00%> (ø)
...a/src/hummock/compaction/tier_compaction_picker.rs 96.30% <100.00%> (+<0.01%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan
Copy link
Member Author

xxchan commented Jun 6, 2022

Just searched "rename" and randomly added some. 🤪 Let's add more when they are encountered! 🐶

Btw, I think adding license doesn't need to be ignored since it does not override other blames?

@xxchan xxchan marked this pull request as ready for review June 6, 2022 07:17
@skyzh
Copy link
Contributor

skyzh commented Jun 6, 2022

Btw, I think adding license doesn't need to be ignored since it does not override other blames?

Agree!

@xxchan xxchan merged commit f239a70 into main Jun 6, 2022
@xxchan xxchan deleted the blame branch June 6, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants