Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grafana): add estimated s3 cost #3000

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 6, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #2854

@skyzh skyzh requested a review from fuyufjh June 6, 2022 08:19
@skyzh skyzh marked this pull request as ready for review June 6, 2022 08:19
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💰

@skyzh skyzh enabled auto-merge (squash) June 6, 2022 08:28
@skyzh skyzh merged commit 90f991f into main Jun 6, 2022
@skyzh skyzh deleted the skyzh/estimated-cost-s3 branch June 6, 2022 08:32
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #3000 (c561b95) into main (be82502) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3000   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         724      724           
  Lines       96982    96982           
=======================================
+ Hits        70773    70775    +2     
+ Misses      26209    26207    -2     
Flag Coverage Δ
rust 72.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/barrier/mod.rs 65.27% <0.00%> (-0.33%) ⬇️
src/storage/src/hummock/local_version_manager.rs 90.22% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/compactor.rs 69.68% <0.00%> (+0.17%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 44.94% <0.00%> (+1.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: estimated cost for s3
2 participants