Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): remove redundant warning #3072

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

as title

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3050

Signed-off-by: tabVersion <[email protected]>
@shanicky shanicky changed the title fix(connector) remove redundant warning fix(connector): remove redundant warning Jun 8, 2022
@tabVersion tabVersion enabled auto-merge (squash) June 8, 2022 09:30
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion merged commit 5a5bd55 into main Jun 8, 2022
@tabVersion tabVersion deleted the tab/warning-remove branch June 8, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector: warning in DatagenSplit
2 participants