Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add random seed for datagen #3124

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

allow datagen to generate random value with specific seed

this pr only works with random int and float. do not support generating deterministic timestamp and varchar.

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

part of #3095

Signed-off-by: tabVersion <[email protected]>
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion enabled auto-merge (squash) June 10, 2022 06:55
@tabVersion tabVersion merged commit 9d2bf48 into main Jun 10, 2022
@tabVersion tabVersion deleted the tab/datagen-random-seed branch June 10, 2022 07:03
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3124 (ff7c80e) into main (46d8875) will increase coverage by 0.11%.
The diff coverage is 96.82%.

@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   73.47%   73.59%   +0.11%     
==========================================
  Files         735      735              
  Lines      100477   100537      +60     
==========================================
+ Hits        73830    73991     +161     
+ Misses      26647    26546     -101     
Flag Coverage Δ
rust 73.59% <96.82%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/datagen/mod.rs 0.00% <ø> (ø)
src/connector/src/datagen/source/reader.rs 82.94% <96.82%> (+82.94%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 43.82% <0.00%> (-1.13%) ⬇️
src/meta/src/barrier/mod.rs 69.13% <0.00%> (-0.33%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.12% <0.00%> (-0.16%) ⬇️
src/connector/src/macros.rs 10.81% <0.00%> (+2.70%) ⬆️
...onnector/src/datagen/source/field_generator/mod.rs 60.71% <0.00%> (+16.07%) ⬆️
src/connector/src/datagen/split.rs 16.66% <0.00%> (+16.66%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants