Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix uneeded async func def #315

Merged
merged 2 commits into from
Feb 14, 2022
Merged

fix: fix uneeded async func def #315

merged 2 commits into from
Feb 14, 2022

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Feb 14, 2022

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@yezizp2012 yezizp2012 requested review from BugenZhao and MrCroxx and removed request for BugenZhao February 14, 2022 13:34
@yezizp2012 yezizp2012 enabled auto-merge (squash) February 14, 2022 13:34
@github-actions github-actions bot added the type/fix Bug fix label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #315 (7d086ca) into main (b37caff) will increase coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #315      +/-   ##
============================================
+ Coverage     74.20%   74.21%   +0.01%     
  Complexity     2665     2665              
============================================
  Files           856      856              
  Lines         48496    48489       -7     
  Branches       1586     1586              
============================================
  Hits          35988    35988              
+ Misses        11696    11689       -7     
  Partials        812      812              
Flag Coverage Δ
java 61.93% <ø> (ø)
rust 79.48% <69.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/dashboard/mod.rs 0.00% <ø> (ø)
rust/meta/src/barrier/command.rs 46.80% <33.33%> (+2.80%) ⬆️
rust/meta/src/stream/meta.rs 56.16% <50.00%> (ø)
rust/meta/src/barrier/mod.rs 68.23% <100.00%> (ø)
rust/meta/src/stream/stream_manager.rs 92.11% <100.00%> (+0.94%) ⬆️
rust/meta/src/hummock/compaction.rs 64.38% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37caff...7d086ca. Read the comment docs.

@yezizp2012 yezizp2012 merged commit 213bb02 into main Feb 14, 2022
@yezizp2012 yezizp2012 deleted the fix/fix-stream-meta-async branch February 14, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants