Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support select Row() #3152

Merged
merged 2 commits into from
Jun 13, 2022
Merged

feat: support select Row() #3152

merged 2 commits into from
Jun 13, 2022

Conversation

cykbls01
Copy link
Contributor

@cykbls01 cykbls01 commented Jun 13, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

select row();

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3152 (f582384) into main (3bca26e) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #3152   +/-   ##
=======================================
  Coverage   73.66%   73.66%           
=======================================
  Files         739      739           
  Lines      101792   101803   +11     
=======================================
+ Hits        74986    74996   +10     
- Misses      26806    26807    +1     
Flag Coverage Δ
rust 73.66% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/src/parser.rs 92.29% <83.33%> (-0.06%) ⬇️
src/meta/src/barrier/mod.rs 69.45% <0.00%> (+0.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@cykbls01 cykbls01 marked this pull request as ready for review June 13, 2022 10:52
@cykbls01 cykbls01 merged commit 9e62f3e into main Jun 13, 2022
@cykbls01 cykbls01 deleted the feat/select_row branch June 13, 2022 11:02
@hengm3467
Copy link
Contributor

@cykbls01 Does the function return all rows? or we can specify conditions for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants