Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): get compute nodes's address from meta server when java frontend starts #323

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

HuaHuaY
Copy link
Contributor

@HuaHuaY HuaHuaY commented Feb 15, 2022

What's changed and what's your intention?

When Java frontend starts, get compute nodes's address from meta server using ListAllNodes rpc interface instead of reading from properties file.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

related #61

@HuaHuaY HuaHuaY changed the title feat(frontend): get compute nodes's address from meta server feat(frontend): get compute nodes's address from meta server when starting Feb 15, 2022
@HuaHuaY HuaHuaY changed the title feat(frontend): get compute nodes's address from meta server when starting feat(frontend): get compute nodes's address from meta server when java frontend starts Feb 15, 2022
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #323 (4d73018) into main (afe52b3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #323      +/-   ##
============================================
- Coverage     74.24%   74.21%   -0.03%     
  Complexity     2668     2668              
============================================
  Files           859      859              
  Lines         48577    48593      +16     
  Branches       1588     1589       +1     
============================================
- Hits          36064    36063       -1     
- Misses        11701    11718      +17     
  Partials        812      812              
Flag Coverage Δ
java 61.85% <0.00%> (-0.07%) ⬇️
rust 79.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/kotlin/com/risingwave/rpc/GrpcMetaClient.kt 0.00% <0.00%> (ø)
...a/com/risingwave/node/RemoteWorkerNodeManager.java 0.00% <0.00%> (ø)
rust/meta/src/hummock/compaction.rs 63.69% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe52b3...4d73018. Read the comment docs.

@HuaHuaY HuaHuaY merged commit 168e260 into main Feb 15, 2022
@HuaHuaY HuaHuaY deleted the zehua/support_java_frontend_reboot branch February 15, 2022 03:28
@BowenXiao1999
Copy link
Contributor

BowenXiao1999 commented Feb 15, 2022

Actually I think the rust version should prioritize over java version.
See #69

@yezizp2012
Copy link
Contributor

We also need this in rust :) See #69

@HuaHuaY will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants