Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): StreamDynamicFilter #3515

Merged
merged 16 commits into from
Jul 5, 2022
Merged

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Jun 28, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Summarize your change: Add StreamDynamicFilter, converting from a non-eq inner join with comparison operator
  • Changes to_stream_plan

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Tracking issue: #3419

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 878 files.

Valid Invalid Ignored Fixed
876 1 1 0
Click to see the invalid file list
  • src/frontend/src/optimizer/plan_node/stream_dynamic_filter.rs

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3515 (8331b3d) into main (3123a55) will increase coverage by 0.01%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main    #3515      +/-   ##
==========================================
+ Coverage   74.29%   74.30%   +0.01%     
==========================================
  Files         787      788       +1     
  Lines      111546   111653     +107     
==========================================
+ Hits        82873    82965      +92     
- Misses      28673    28688      +15     
Flag Coverage Δ
rust 74.30% <82.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/optimizer/plan_node/mod.rs 97.91% <ø> (ø)
...rontend/src/optimizer/plan_node/stream_hash_agg.rs 97.26% <0.00%> (+1.31%) ⬆️
src/frontend/src/expr/mod.rs 82.26% <47.82%> (-3.06%) ⬇️
...rc/frontend/src/optimizer/property/distribution.rs 91.52% <60.00%> (-1.52%) ⬇️
...d/src/optimizer/plan_node/stream_dynamic_filter.rs 87.87% <87.87%> (ø)
...c/frontend/src/optimizer/plan_node/logical_join.rs 91.11% <91.54%> (+0.24%) ⬆️
...frontend/src/optimizer/plan_node/batch_hash_agg.rs 76.11% <100.00%> (+1.11%) ⬆️
...ontend/src/optimizer/plan_node/batch_simple_agg.rs 83.78% <100.00%> (+1.35%) ⬆️
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/meta/src/barrier/mod.rs 81.55% <0.00%> (+0.19%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jon-chuang jon-chuang requested a review from fuyufjh June 29, 2022 07:22
@fuyufjh fuyufjh requested a review from st1page June 29, 2022 11:13
@jon-chuang
Copy link
Contributor Author

Hey @st1page are there any issues with this? Next PR will be able to pass e2e tests so if not could we merge this one?

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

Hey @jon-chuang, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot merged commit 3541fa1 into main Jul 5, 2022
@mergify mergify bot deleted the jon/dynamic-filter-planner branch July 5, 2022 12:56
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* initial

* do-appply-planner-test

* fmt

* clippy

* license

* minor

* stash

* fix required dist, output indices

* fmt

* do-apply-planner-test

* fix

Co-authored-by: TennyZhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants