Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add metrics for compact task splits count #3693

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jul 6, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

add metrics for monitor compact task splits count

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #3693 (03b445d) into main (e4ba2fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3693   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         791      791           
  Lines      111593   111605   +12     
=======================================
+ Hits        83039    83055   +16     
+ Misses      28554    28550    -4     
Flag Coverage Δ
rust 74.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/compactor.rs 78.78% <100.00%> (+0.08%) ⬆️
src/storage/src/monitor/state_store_metrics.rs 87.00% <100.00%> (+0.31%) ⬆️
src/storage/src/hummock/local_version_manager.rs 81.49% <0.00%> (+0.11%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️
src/meta/src/manager/id.rs 96.06% <0.00%> (+1.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Li0k Li0k force-pushed the li0k/feat_disable_parallel_compact branch from f258c31 to cfe05c0 Compare July 6, 2022 10:22
@Li0k Li0k changed the title feat(storage): add disable_parallel_compact and add metrics feat(metrics): add metrics for compact task splits count Jul 6, 2022
@mergify mergify bot merged commit 753fd97 into main Jul 6, 2022
@mergify mergify bot deleted the li0k/feat_disable_parallel_compact branch July 6, 2022 11:14
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…abs#3693)

* feat(storage): add disable_parallel_compact and add metrics

* chore(storage): remove config for disable_compact_parallel

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants