Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): project with mapping #471

Merged
merged 6 commits into from
Feb 22, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Feb 22, 2022

What's changed and what's your intention?

  • add some method on mapping
  • new a logicalproject from a mapping
  • refactor the col prune with mapping

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@st1page st1page enabled auto-merge (squash) February 22, 2022 06:36
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe give an example in the future for each method that creates a ColIndexMapping. It was confusing when I first approach all kinds of mapping in Calcite.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #471 (943d234) into main (bdec529) will decrease coverage by 0.01%.
The diff coverage is 25.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #471      +/-   ##
============================================
- Coverage     72.81%   72.79%   -0.02%     
  Complexity     2711     2711              
============================================
  Files           871      871              
  Lines         48691    48713      +22     
  Branches       1554     1554              
============================================
+ Hits          35454    35461       +7     
- Misses        12426    12441      +15     
  Partials        811      811              
Flag Coverage Δ
java 63.43% <ø> (ø)
rust 76.78% <25.92%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...st/frontend/src/optimizer/plan_node/col_pruning.rs 0.00% <0.00%> (ø)
...rontend/src/optimizer/plan_node/logical_project.rs 0.00% <0.00%> (ø)
rust/frontend/src/utils/column_index_mapping.rs 91.74% <50.00%> (-6.16%) ⬇️
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdec529...943d234. Read the comment docs.

@st1page st1page merged commit 15801bd into main Feb 22, 2022
@st1page st1page deleted the sts/optimizer_project_with_mapping branch February 22, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants