Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(streaming): correct vec capacity in get_hash_values #52

Merged
merged 3 commits into from
Jan 29, 2022
Merged

fix(streaming): correct vec capacity in get_hash_values #52

merged 3 commits into from
Jan 29, 2022

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jan 29, 2022 •
edited
Loading

What's changed and what's your intention?

  • correct vec capacity in get_hash_values

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jan 29, 2022
fuyufjh
fuyufjh approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may just use vec![] because the next line resizes it with self.capacity()

@yuhao-su yuhao-su enabled auto-merge (squash) January 29, 2022 10:11
@yuhao-su yuhao-su merged commit 33fd670 into main Jan 29, 2022
@yuhao-su yuhao-su deleted the improve_get_hash_values branch January 29, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhao-su @fuyufjh