Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto): add hidden column in Column Desc #530

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Feb 24, 2022

What's changed and what's your intention?

add is_hidden in Column Desc proto

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💦💦💦

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #530 (1a97fcd) into main (3809a21) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #530      +/-   ##
============================================
- Coverage     72.77%   72.77%   -0.01%     
  Complexity     2709     2709              
============================================
  Files           877      877              
  Lines         49147    49150       +3     
  Branches       1557     1557              
============================================
+ Hits          35765    35767       +2     
- Misses        12571    12572       +1     
  Partials        811      811              
Flag Coverage Δ
java 63.41% <ø> (ø)
rust 76.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/handler/create_table.rs 97.82% <100.00%> (+0.04%) ⬆️
rust/stream/src/executor/mview/materialize.rs 79.09% <100.00%> (+0.38%) ⬆️
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3809a21...1a97fcd. Read the comment docs.

@st1page st1page merged commit 86680b2 into main Feb 24, 2022
@st1page st1page deleted the sts/hidden_column branch February 24, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants