feat(frontend): add execution context to replace session impl #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenXiao1999
commented
Mar 7, 2022
rust/frontend/src/session.rs
Outdated
Comment on lines
19
to
21
| pub struct ExecutionContext<'a> { | ||
| pub session: &'a SessionImpl, | ||
| } |
There was a problem hiding this comment.
Do not use Rc or Arc here, so the lifetime.
rust/frontend/src/handler/mod.rs
Outdated
|
|
||
| mod create_source; | ||
| pub mod create_table; | ||
| pub mod drop_table; | ||
| mod explain; | ||
|
|
||
| pub(super) async fn handle(session: &SessionImpl, stmt: Statement) -> Result<PgResponse> { | ||
| let context = ExecutionContext::new(session); |
There was a problem hiding this comment.
It's not mut now cuz rust clippy do not allow it. Change in need.
BowenXiao1999
requested review from
st1page,
liurenjie1024,
fuyufjh,
neverchanje and
xiangjinwu
BowenXiao1999
force-pushed
the
bw_wrap_execution_context
branch
from
99a98db
to
fcbb1b0
Compare
BowenXiao1999
force-pushed
the
bw_wrap_execution_context
branch
from
fcbb1b0
to
20860a7
Compare
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
============================================
- Coverage 71.77% 71.55% -0.23%
Complexity 2706 2706
============================================
Files 899 901 +2
Lines 51737 52034 +297
Branches 1751 1781 +30
============================================
+ Hits 37135 37232 +97
- Misses 13787 13987 +200
Partials 815 815
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Motivation: #700
Checklist
Refer to a related PR or issue link (optional)