feat(frontend): make expr in explain output concise #802
Conversation
| let agg_name = format!("{:?}", agg_call.agg_kind()); | ||
| let mut builder = f.debug_tuple(&agg_name); | ||
| agg_call.inputs().iter().for_each(|child| { | ||
| builder.field(child); | ||
| }); | ||
| builder.finish() |
There was a problem hiding this comment.
impl fmt::Debug for AggCall?
There was a problem hiding this comment.
My intention is to keep the default verbose format available via {:#?}, so I am not overriding individual variants (Literal, InputRef, FunctionCall, AggCall).
There was a problem hiding this comment.
I'm afraid this intention may not be easy to find out by new comers. Why not impl a ToExplain for all ast and keep the behaviors of Debug consistent?
There was a problem hiding this comment.
Introducing a new trait does not work because the debug_struct / debug_list helpers on std::fmt::Formatter always uses Debug output. What about adding some doc comments on ExprImpl? If a developer is not satisfied with the overloaded concise format, they are expected to know Debug has been manually implemented.
There was a problem hiding this comment.
Ok, it's fine for now.
xiangjinwu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #802 +/- ##
=========================================
Coverage 72.22% 72.23%
Complexity 2766 2766
=========================================
Files 923 923
Lines 53652 53683 +31
Branches 1787 1787
=========================================
+ Hits 38752 38776 +24
- Misses 14010 14017 +7
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangjinwu
force-pushed
the
rust-frontend-explain-fmt
branch
from
c9ba847
to
c48571f
Compare
xiangjinwu
force-pushed
the
rust-frontend-explain-fmt
branch
from
c48571f
to
bd75f68
Compare
What's changed and what's your intention?
Implement
Debugmanually forExprImplso that plan nodes can explain with a more concise format. It is intended to work withstd::fmt::Formatter::debug_list. When verbosity is preferred, it is still available via the alternate flag{:#?}.Checklist
Refer to a related PR or issue link (optional)