Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support BatchInsert #879

Merged
merged 2 commits into from
Mar 14, 2022
Merged

feat(frontend): support BatchInsert #879

merged 2 commits into from
Mar 14, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 14, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. Currently it cannot be tested, as:

explain insert into t1 values (1), (2), (3);
thread 'tokio-runtime-worker' panicked at 'not yet implemented', frontend/src/optimizer/plan_node/logical_values.rs:77:9

explain insert into t1 select * from t0;
thread 'tokio-runtime-worker' panicked at 'insert at index 2 exceeds fixbitset size 2',

Will add plan tests after LogicalValues have been implemented.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #837

also fixes comment in #840

Signed-off-by: Alex Chi <[email protected]>
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #879 (4d4f83f) into main (7a8ed2d) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #879      +/-   ##
============================================
+ Coverage     72.27%   72.33%   +0.05%     
  Complexity     2766     2766              
============================================
  Files           931      934       +3     
  Lines         54740    54833      +93     
  Branches       1787     1787              
============================================
+ Hits          39564    39661      +97     
+ Misses        14286    14282       -4     
  Partials        890      890              
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.81% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cmd/src/bin/risingwave.rs 100.00% <ø> (ø)
...t/frontend/src/optimizer/plan_node/batch_insert.rs 0.00% <0.00%> (ø)
...frontend/src/optimizer/plan_node/logical_filter.rs 88.70% <0.00%> (ø)
...frontend/src/optimizer/plan_node/logical_insert.rs 57.89% <0.00%> (-6.82%) ⬇️
rust/frontend/src/optimizer/plan_node/mod.rs 27.65% <0.00%> (-0.61%) ⬇️
rust/utils/logging/src/lib.rs 0.00% <ø> (ø)
rust/frontend/src/expr/mod.rs 70.00% <0.00%> (-6.09%) ⬇️
rust/stream/src/task/barrier_manager.rs 83.72% <0.00%> (-2.95%) ⬇️
rust/frontend/src/planner/table_ref.rs 100.00% <0.00%> (ø)
...t/frontend/src/optimizer/plan_node/logical_scan.rs 88.00% <0.00%> (ø)
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 832f167 into main Mar 14, 2022
@skyzh skyzh deleted the skyzh/logical-insert-batch branch March 14, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend: LogicalInsert not implemented
2 participants