Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): create query handler #907

Merged
merged 4 commits into from
Mar 15, 2022
Merged

feat(frontend): create query handler #907

merged 4 commits into from
Mar 15, 2022

Conversation

cykbls01
Copy link
Contributor

@cykbls01 cykbls01 commented Mar 14, 2022

What's changed and what's your intention?

implement query handler

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#698

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #907 (2e66511) into main (044cff6) will decrease coverage by 0.04%.
The diff coverage is 25.58%.

@@             Coverage Diff              @@
##               main     #907      +/-   ##
============================================
- Coverage     72.49%   72.44%   -0.05%     
  Complexity     2766     2766              
============================================
  Files           936      937       +1     
  Lines         55268    55322      +54     
  Branches       1787     1787              
============================================
+ Hits          40067    40079      +12     
- Misses        14311    14353      +42     
  Partials        890      890              
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 76.91% <25.58%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../frontend/src/optimizer/plan_node/batch_project.rs 0.00% <0.00%> (ø)
...t/frontend/src/optimizer/plan_node/batch_values.rs 0.00% <0.00%> (ø)
rust/frontend/src/handler/query.rs 21.21% <21.21%> (ø)
rust/frontend/src/handler/mod.rs 83.33% <100.00%> (-7.58%) ⬇️
rust/rpc_client/src/compute_client.rs 74.13% <100.00%> (-19.05%) ⬇️
rust/meta/src/hummock/compaction.rs 81.56% <0.00%> (-0.56%) ⬇️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
rust/meta/src/cluster/mod.rs 74.29% <0.00%> (+0.35%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

rust/rpc_client/src/compute_client.rs Show resolved Hide resolved
impl ToBatchProst for BatchProject {
fn to_batch_prost_body(&self) -> NodeBody {
NodeBody::Project(ProjectNode {
select_list: vec![],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select_list: vec![],
select_list: self.logical.exprs.iter().map(|e| e.to_prost()),

You can fully implement this in later pr, it should not be left blank.
I've glanced at ExprImpl and it seems to have no to_prost, it'd need some work.

rust/frontend/src/handler/query.rs Outdated Show resolved Hide resolved
rust/frontend/src/handler/query.rs Outdated Show resolved Hide resolved
rust/frontend/src/handler/query.rs Outdated Show resolved Hide resolved
rust/frontend/src/handler/query.rs Outdated Show resolved Hide resolved
@neverchanje neverchanje marked this pull request as ready for review March 15, 2022 04:49
@neverchanje neverchanje merged commit d158656 into main Mar 15, 2022
@neverchanje neverchanje deleted the feat/query_handler branch March 15, 2022 05:19
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants