Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): add risedev p #916

Merged
merged 2 commits into from
Mar 15, 2022
Merged

feat(risedev): add risedev p #916

merged 2 commits into from
Mar 15, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 15, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

This PR adds ./risedev p command to start a minimal frontend-v2 environment.

There's also some other changes:

  • add risedev to the rust path, so that people won't need to cd back and forth.
  • rename risedev folder to risedevtool, as risedev can't be both a file and a folder under the same directory.
  • update readme

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <[email protected]>
Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #916 (95ceafe) into main (0ad4b1f) will decrease coverage by 1.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #916      +/-   ##
============================================
- Coverage     72.49%   71.31%   -1.18%     
  Complexity     2766     2766              
============================================
  Files           936      964      +28     
  Lines         55274    56381    +1107     
  Branches       1787     1787              
============================================
+ Hits          40070    40208     +138     
- Misses        14314    15283     +969     
  Partials        890      890              
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 75.23% <ø> (-1.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/risedevtool/src/bin/risedev-config.rs 0.00% <ø> (ø)
rust/risedevtool/src/bin/risedev-playground.rs 0.00% <ø> (ø)
rust/risedevtool/src/config.rs 0.00% <ø> (ø)
rust/risedevtool/src/config/dollar_expander.rs 83.33% <ø> (ø)
rust/risedevtool/src/config/id_expander.rs 92.85% <ø> (ø)
rust/risedevtool/src/config/provide_expander.rs 87.75% <ø> (ø)
rust/risedevtool/src/config/service_config.rs 0.00% <ø> (ø)
rust/risedevtool/src/config/use_expander.rs 85.29% <ø> (ø)
rust/risedevtool/src/config_gen/frontend_gen.rs 0.00% <ø> (ø)
rust/risedevtool/src/config_gen/grafana_gen.rs 0.00% <ø> (ø)
... and 49 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 98b5f10 into main Mar 15, 2022
@skyzh skyzh deleted the skyzh/risedev-p branch March 15, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants