Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): simplify batch agg-nodes #9176

Merged
merged 3 commits into from
Apr 14, 2023
Merged

refactor(plan_node): simplify batch agg-nodes #9176

merged 3 commits into from
Apr 14, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 enabled auto-merge April 14, 2023 03:03
@ice1000 ice1000 added this pull request to the merge queue Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #9176 (678ee1f) into main (fdd319e) will increase coverage by 0.00%.
The diff coverage is 96.82%.

@@           Coverage Diff           @@
##             main    #9176   +/-   ##
=======================================
  Coverage   70.83%   70.84%           
=======================================
  Files        1200     1200           
  Lines      200057   200043   -14     
=======================================
- Hits       141720   141714    -6     
+ Misses      58337    58329    -8     
Flag Coverage Δ
rust 70.84% <96.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/optimizer/plan_node/batch_sort_agg.rs 78.16% <93.75%> (-0.50%) ⬇️
...frontend/src/optimizer/plan_node/batch_hash_agg.rs 80.00% <94.11%> (-0.38%) ⬇️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 84.28% <100.00%> (+0.45%) ⬆️
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 96.28% <100.00%> (-0.34%) ⬇️
.../frontend/src/optimizer/plan_node/logical_union.rs 99.60% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants