feat(frontend): get pg_field_descs from boudstatement #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #950 +/- ##
============================================
+ Coverage 71.52% 71.54% +0.01%
Complexity 2766 2766
============================================
Files 973 973
Lines 57427 57473 +46
Branches 1790 1790
============================================
+ Hits 41076 41119 +43
- Misses 15460 15463 +3
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
neverchanje
reviewed
Mar 16, 2022
neverchanje
approved these changes
Mar 16, 2022
skyzh
reviewed
Mar 16, 2022
| @@ -27,7 +25,7 @@ pub async fn handle_query(context: QueryContext, query: Box<Query>) -> Result<Pg | |||
| let mut binder = Binder::new(catalog); | |||
| let bound = binder.bind(Statement::Query(query))?; | |||
| let plan = Planner::new(Rc::new(RefCell::new(context))) | |||
| .plan(bound)? | |||
| .plan(bound.clone())? | |||
There was a problem hiding this comment.
Is it possible to pass a ref to bound statement into the planner?
If we have an insert with thousands of values, I suspect this could be slow.
There was a problem hiding this comment.
Well, I think it's better to take &BoundStatement for pg_field_descs. The planner needs ownership to reduce clones.
|
Seems the logic of extracting name & type is redundant. Is it possible to just use |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
get pg_field_descs from boudstatement to build pg_response
Checklist
Refer to a related PR or issue link (optional)