Merge pull request #54 from clemasso/develop

fix display glitch in vintage and revision print functions

NEWS.md

@@ -20,6 +20,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 * pivot from {formattable} dependency to {flextable} to build the tables
 * `simulate_long()` is now an exported function to construct datasets example
 
+### Fixed
+
+* solve a display glitch in functions print.rjd3rev_vintages() and print.rjd3rev_revisions() 
+
 
 ## [1.3.2] - 2024-07-10
 

R/revision_analysis.R

@@ -73,7 +73,7 @@
 #'
 #' ## Call using all default parameters
 #' rslt1 <- revision_analysis(vintages)
-#' # render_report(rslt1)
+#' # render_report(rslt1, output_file = "report1", output_dir = "C:/Users/xxx")
 #' summary(rslt1) # formatted summary only
 #' View(rslt1) # formatted tables in viewer panel
 #'
@@ -82,7 +82,8 @@
 #' ## performed automatically (if transf.diff is let to its default option) but `transf.log`
 #' ## must be set to TRUE manually whenever a log-transformation of the data is necessary
 #' rslt2 <- revision_analysis(vintages, gap = 1, view = "diagonal", n.releases = 3)
-#' # render_report(rslt2)
+#' # render_report(rslt2, output_file = "report2", output_dir = "C:/Users/xxx",
+#' # output_format = "word_document", plot_revisions = TRUE)
 #' summary(rslt2)
 #' View(rslt2)
 #'
@@ -93,7 +94,7 @@
 #' vintage_selection = c(start = "2012-12-31", end = "2018-06-30")
 #' )
 #' rslt3 <- revision_analysis(vintages, gap = 2, view = "vertical")
-#' #render_report(rslt3)
+#' #render_report(rslt3, output_file = "report2", output_dir = "C:/Users/xxx", plot_revisions = TRUE)
 #' summary(rslt3)
 #' View(rslt3)
 #'

R/revisions.R

@@ -112,7 +112,6 @@ plot.rjd3rev_revisions <- function(x, view = c("vertical", "diagonal"), n_rev =
 #' @exportS3Method print rjd3rev_revisions
 #' @export
 #'
-
 print.rjd3rev_revisions <- function(x, n_row = 12, n_col = 3, ...) {
 
  # Check counts
@@ -132,7 +131,7 @@ print.rjd3rev_revisions <- function(x, n_row = 12, n_col = 3, ...) {
  frequency = freq,
  end = end_period)
  extract_hv <- x$horizontal_view[(n_col_tot - n_col + 1):n_col_tot, (n_row_tot - n_row + 1):n_row_tot]
- extract_dv <- stats::ts(x$diagonal_view[1:n_row, 1:n_col],
+ extract_dv <- stats::ts(x$diagonal_view[(n_row_tot - n_row + 1):n_row_tot, 1:n_col],
  frequency = freq,
  end = end_period)
 
@@ -153,7 +152,7 @@ print.rjd3rev_revisions <- function(x, n_row = 12, n_col = 3, ...) {
 summary.rjd3rev_revisions <- function(object, ...) {
  x <- object
  vv <- x$vertical_view
- cat("Number of releases: ", ncol(vv))
+ cat("Number of release revisions: ", ncol(vv))
  cat("\nCovered period:")
  cat("\n \tFrom: ", stats::start(vv))
  cat("\n \tTo: ", stats::end(vv))

R/vintages.R

@@ -526,7 +526,7 @@ print.rjd3rev_vintages <- function(x,
  frequency = freq,
  end = end_period)
  extract_hv <- x$horizontal_view[(n_col_tot - n_col + 1):n_col_tot, (n_row_tot - n_row + 1):n_row_tot]
- extract_dv <- stats::ts(x$diagonal_view[1:n_row, 1:n_col],
+ extract_dv <- stats::ts(x$diagonal_view[(n_row_tot - n_row + 1):n_row_tot, 1:n_col],
  frequency = freq,
  end = end_period)
 

README.Rmd

@@ -156,6 +156,7 @@ render_report(
 
 summary(rslt)
 print(rslt)
+View(rslt)
 ```
 
 ## Additional information