I have added user-defined thresholds based on #49 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+65
|
|
||
| # options initialization | ||
| if (is.null(getOption("theil_u1_threshold"))) { | ||
| set_thresholds_to_default("theil_u1_threshold") | ||
| } | ||
| if (is.null(getOption("theil_u2_threshold"))) { | ||
| set_thresholds_to_default("theil_u2_threshold") | ||
| } | ||
| if (is.null(getOption("t_threshold"))) { | ||
| set_thresholds_to_default("t_threshold") | ||
| } | ||
| if (is.null(getOption("augmented_t_threshold"))) { | ||
| set_thresholds_to_default("augmented_t_threshold") | ||
| } | ||
| if (is.null(getOption("slope_and_drift_threshold"))) { | ||
| set_thresholds_to_default("slope_and_drift_threshold") | ||
| } | ||
| if (is.null(getOption("eff1_threshold"))) { | ||
| set_thresholds_to_default("eff1_threshold") | ||
| } | ||
| if (is.null(getOption("eff2_threshold"))) { | ||
| set_thresholds_to_default("eff2_threshold") | ||
| } | ||
| if (is.null(getOption("orth1_threshold"))) { | ||
| set_thresholds_to_default("orth1_threshold") | ||
| } | ||
| if (is.null(getOption("orth2_threshold"))) { | ||
| set_thresholds_to_default("orth2_threshold") | ||
| } | ||
| if (is.null(getOption("autocorr_threshold"))) { | ||
| set_thresholds_to_default("autocorr_threshold") | ||
| } | ||
| if (is.null(getOption("seas_threshold"))) { | ||
| set_thresholds_to_default("seas_threshold") | ||
| } | ||
| if (is.null(getOption("signal_noise1_threshold"))) { | ||
| set_thresholds_to_default("signal_noise1_threshold") | ||
| } | ||
| if (is.null(getOption("signal_noise2_threshold"))) { | ||
| set_thresholds_to_default("signal_noise2_threshold") | ||
| } | ||
|
|
||
| if (is.null(getOption("jb_res_threshold"))) { | ||
| set_thresholds_to_default("jb_res_threshold") | ||
| } | ||
| if (is.null(getOption("bp_res_threshold"))) { | ||
| set_thresholds_to_default("bp_res_threshold") | ||
| } | ||
| if (is.null(getOption("white_res_threshold"))) { | ||
| set_thresholds_to_default("white_res_threshold") | ||
| } | ||
| if (is.null(getOption("arch_res_threshold"))) { | ||
| set_thresholds_to_default("arch_res_threshold") | ||
| } |
There was a problem hiding this comment.
why not initialise all the options when the package is loaded?
R/revision_analysis.R
Outdated
Comment on lines
107
to
109
| #' options(list(augmented_t_threshold = c(severe = 0.005, bad = 0.01, uncertain = 0.05), | ||
| #' slope_and_drift_threshold = c(severe = 0.005, bad = 0.05, uncertain = 0.10), | ||
| #' theil_u2_threshold = c(uncertain = .5, bad = .7, severe = 1))) |
There was a problem hiding this comment.
options(list(...))) <=> options(...)
R/revision_analysis.R
Outdated
| thr = quality_thresholds$slope_and_drift, | ||
| thr_res = quality_thresholds_res) | ||
| thr = getOption("slope_and_drift_threshold"), | ||
| thr_res = res_thresholds) |
There was a problem hiding this comment.
You should detail each threshold individually. This will make it easier for the user to set thresholds individually.
For example:
instead of:
res_thresholds <- list(
jb = getOption("jb_res_threshold"),
bp = getOption("bp_res_threshold"),
white = getOption("white_res_threshold"),
arch = getOption("arch_res_threshold")
)
sd_test_evaluator(..., thr_res = res_thresholds)You can write:
res_thresholds <- list(
jb = getOption("jb_res_threshold"),
bp = getOption("bp_res_threshold"),
white = getOption("white_res_threshold"),
arch = getOption("arch_res_threshold")
)
sd_test_evaluator(...,
jb = getOption("jb_res_threshold"),
bp = getOption("bp_res_threshold"),
white = getOption("white_res_threshold"),
arch = getOption("arch_res_threshold")
)Maybe the best is to add an argument ... to eval_test() instead of threshold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.