Fix crashes in XMPPvCardTempEmail and XMPPvCardTempTel initialize #1162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1050 and #1118.
Setter methods in
XMPPcVardTempEmail
andXMPPcVardTempTel
had typing mistakes. Must have been happened sometime during 3.7 to 4.0 transition.These types do not allow adding properties, that's why the allocated size is compared to the size of
NSXMLElement
ininitialize
.Every added property has to have matching get and set overwrites, otherwise ObjC will allocate memory for the property and the size check will fail.
The linked issue describe that behavior.
I also added missing implementation for
TEL
and few tests forXMPPvCardTemp
.