Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV filtering comments #68

Open
vasiliosz opened this issue Dec 14, 2015 · 2 comments
Open

SV filtering comments #68

vasiliosz opened this issue Dec 14, 2015 · 2 comments
Assignees
Milestone

Comments

@vasiliosz
Copy link
Collaborator

Hej @moonso,

The new SV filters work nicely. Two quick thoughts:

  • Dynamic population of SV types in filter.
    For example, if only types DEL, INV and BND exist in my VCF - the other filter options should not be there.
  • Show total vs filtered count.
    This is important I think. Since you're only loading 31 variants at a time, it will be useful to know how many variants I've matched in my filter (vs the total available in the VCF)
@moonso
Copy link
Collaborator

moonso commented Dec 14, 2015

The problem with your first suggestion is that one has to parse through the whole file for this functionality, which would take some time if there are millions of variants.
We could look at the vcf header but it is not always correct.

For the second thing we could try to implement it ands how it works.
Where and how should we display the result?

@vasiliosz
Copy link
Collaborator Author

OK, I understand for the first one.

For the second it can be as simple as alerting the user to the fact that some filter is active. Like:
inklistrad_bild_14_12_15_19_24

More advanced would be to add small bootstrap badges with x-marks on top for each filter. Where clicking on them would remove the filter in question.

@moonso moonso self-assigned this Feb 4, 2016
@robinandeer robinandeer modified the milestone: v1.0.0 Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants