Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on the Robot abstraction #33

Closed
4 of 11 tasks
diegoferigo opened this issue Jun 24, 2019 · 3 comments
Closed
4 of 11 tasks

Discussion on the Robot abstraction #33

diegoferigo opened this issue Jun 24, 2019 · 3 comments

Comments

@diegoferigo
Copy link
Member

diegoferigo commented Jun 24, 2019

Currently the Robot interface has only the support of getting and setting joint values. It is enough for the simple environments we have developed, but definitely it has to be extended. I open this issue as placeholder for the discussion about how to structure the interface.

An initial list of feature we need to have is the following:

  • Joints (almost finalized)
    • Position
    • Velocity
    • Acceleration
    • Torque
    • PID
  • Links
    • Pose (frame orientation + position)
  • Sensors
    • IMU
    • Camera
    • F/T (not yet supported by Ignition Gazebo)
  • Other
    • Floating base
    • Contact wrenches

The existing interfaces are the following: gympp::Robot and gym_ignition.base.Robot.

Currently the robot interface is unique. Likely this is not scalable, there would be too many methods. We should think how to split it in many interfaces while maintaining consistency between python and C++.

Reminder: the python interface will switch to numpy arrays soon

@DanielePucci
Copy link

@diegoferigo joint torques may be added?

@diegoferigo
Copy link
Member Author

diegoferigo commented Jun 24, 2019

I thought they were already in the list, of course joint torques. Joint forces can be already applied but not yet read.

@diegoferigo
Copy link
Member Author

Excluding sensors, all the other abstractions have been implemented in the new ScenarI/O bindings #158. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants