-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use a simple loop to load all glyphs during a save as
- Loading branch information
1 parent
2a44345
commit a912b50
Showing
2 changed files
with
5 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a912b50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typemytype ok with the
for
loop, but what does the changes inLib/defcon/tools/notifications.py
have to do with it? Now it's too late to split the commits or modify the commit message as you pushed to master already.What was the other change about?
a912b50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see you just reverted that with 86ff29a. sorry for the noise
a912b50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other change was something I was testing out related to #102
Ive already reverted the commit, have to investigate the logic a bit further :)