fix: do not depend on git-lfs being installed during git clone #130
Conversation
The current git-lfs integration runs `git lfs pull` after the normal git operations. We therefore setup the git repositories to essentially do nothing on clone/fetch/pull/... However, the way this is done so far is by using the `--skip` options to git-lfs ... which relies on git-lfs itself. This is a problem on platforms where installing git-lfs is an issue. Use pass-through filters that do not rely on git-lfs during cloning instead. The "real" setup is done after the import anyways.
|
Could you please provide more context? I currently see a warning when git-lfs is not installed: |
Mmmmm I'll have to test things out again. Didn't write the detail. In the current setup, we want to be able to disable some packages and not other. For this to work we had to define the Maybe what would have been the right fix, is to not define them if one does not want to install LFS at all. |
Yeah, my thoughts exactly. |
|
Did manage the other way, but I think there is still a bug related to enabling or disabling of packages. Just got very low priority for us, I'll close the PR but keep the branch. |
The current git-lfs integration runs
git lfs pullafter the normal git operations. We therefore setup the git repositories to essentially do nothing on clone/fetch/pull/...However, the way this is done so far is by using the
--skipoptions to git-lfs ... which relies on git-lfs itself. This is a problem on platforms where installing git-lfs is an issue.Use pass-through filters that do not rely on git-lfs during cloning instead. The "real" setup is done after the import anyways.