Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of config-*@ / data-*@ #25

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Nov 22, 2018

# parent
fields:
  foo:
    data-options@: ['\Grav\Plugin\MyPlugin::foo', false]
# child
fields:
  import@:
    type: blueprints.yaml:form/fields
    context: plugins://myplugin
  foo:
    unset-data-options@@: true
    data-options@: ['\Grav\Plugin\MyPlugin::foo', true]

See also #23 and #24

```yaml
# parent
fields:
  foo:
    data-options@: ['\Grav\Plugin\MyPlugin::foo', false]
```

```yaml
# child
fields:
  import@:
    type: blueprints.yaml:form/fields
    context: plugins://myplugin
  foo:
    unset-data-options@@: true
    data-options@: ['\Grav\Plugin\MyPlugin::foo', true]
```
@mahagr
Copy link
Contributor

mahagr commented Jan 6, 2020

@drzraf I'm not seeing why this fixes the override. Can you explain it to me? Also, please update your code to the latest version, thanks.

@mahagr
Copy link
Contributor

mahagr commented May 14, 2022

Ping

@drzraf
Copy link
Contributor Author

drzraf commented May 14, 2022

Looking at it today, I'm not sure. The idea was to support the presence of the data- string before the @ which, IRC, wasn't (is still not) supported.
I think I had getgrav/grav-plugin-form#336 in mind (see my last comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants