-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 0.11.4? #133
Comments
Rack::Session::SessionId was introduced at #146 and fixed this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In 0.11.4 the following change was introduced:
3ee0426
I'm seeing this exception raised in Rack v2.2.3.1:
This can be traced to this line:
https:/rack/rack/blob/925a4a6599ab26b4f3455b525393fe155d443655/lib/rack/session/abstract/id.rb#L482-L484
It seems that the data returned by
set_session
is a simple string, but a different data structure is expected:redis-session-store/lib/redis-session-store.rb
Lines 127 to 139 in e9a7d80
If you dig into ActionDispatch::Session::CookieStore we can see that it's
write_session
implementation return a Rack::Session::SessionId instance (albeit decorated):https:/rails/rails/blob/04972d9b9ef60796dc8f0917817b5392d61fcf09/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb#L104-L107
If one returns an appropriately crafted instance this package works again.
The text was updated successfully, but these errors were encountered: