Load locals as module, with enable/disable and uncaughtOnly options #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
enable
flag that can be toggled dynamically at runtime.uncaughtOnly
flag that can be toggled dynamically at runtime.Using the
enable
anduncaughtOnly
flags at runtime can allow capturing locals for specific code paths or time intervals, while avoiding perf impact at other times.Usage example:
Notes:
To support non-Node build environments (e.g. vercel/pkg), a try/catch around the require('inspector') was considered.
This would allow these environments to build successfully, without needing a separate Locals module. But since the
require('inspector)
might lead to other possible conflicts, even when the locals feature isn't enabled, loading the module separately looked like the most reliably safe option.Type of change
Related issues
Fixes: #921
ch79594
Development
Code review